[Mlir-commits] [mlir] [mlir][python] remove mixins (PR #68853)

[Oleksandr Alex Zinenko]

ftynse wrote:

This looks like an improvement over the previous state, at least from my better understanding of how this works. Maybe we can figure out a mechanism that checks whether the `FooBarOp` derived classes are having the required decorators to avoid the footgun.

As for handling changes to ODS op specification, this doesn't make it any worse. In the existing approach, we would have also needed to update the mixin classes when ODS changed (there have been several cases recently). I think the best way to guard against this is to keep improving the generated API (e.g., generate overloads) so that the amount of handwritten builders becomes minimal.

https://github.com/llvm/llvm-project/pull/68853