[Mlir-commits] [mlir] [mlir][linalg] Add TransposeConv2D Pass (PR #68567)

[Andrzej Warzyński]

banach-space wrote:

> > Thanks for the contribution! My main comment would be that this pass is a bit limited ATM:
> > > Convert conv_2d_nhwc_fhwc to conv_2d_nhwc_hwcf
> > 
> > 
> > Why not support conversions in both directions?
> 
> Sure, although I'm not 100% clear what "both directions" means here. Should the pass also run on `conv_2d_nhwc_hwcf` and convert it to `fwhc`?

Yes, that's what I had in mind. And in general, it would be helpful if you expanded a bit on the use cases for this in the summary (and how would this be used). Otherwise it feels a bit like some arbitrary transformation. I am sure it isn't, but it's just not clear from the summary. More specifically, is there a hardware that works better with one type over the other? And some frameworks tend to generate the "wrong" type? Just curious, but I suspect other people might be too.

Also, apologies for the delay responding and thanks for the updates :)

https://github.com/llvm/llvm-project/pull/68567