[Mlir-commits] [mlir] [mlir][python] remove mixins (PR #68853)

[Jacques Pienaar]

https://github.com/jpienaar approved this pull request.

Overall this seems like an improvement. I'd love for a way to avoid things accidentally getting out of sync. I can't say I have a satisfying answer for that ... it seems it is mostly just the "constructor" that is modified and potentially some extra class members, but don't know if there is mechanism to make that easy while ensuring SOT is ODS still. Well and I'd want overwrites in python to be the way to do so, but have it be minimal, non-magical (e.g., the mixin file approach is a bit magical) but also avoid footgun if operands etc change.

https://github.com/llvm/llvm-project/pull/68853