[Mlir-commits] [mlir] [openacc][openmp] Add dialect representation for acc atomic operations (PR #65493)

Guray Ozen llvmlistbot at llvm.org
Wed Oct 18 04:25:55 PDT 2023


grypp wrote:

Hey, I've just seen this PR, I understand the need for a common atomic interface between these two models. 

I am little concerned about the `OpenACCMPCommon` folder is in the `dialect` folder, but there is no dialect definition here? There is a single interface `AtomicInterface`, imho atomics can be used beyond just OpenACC/MP. 

Would make sense to delete the `OpenACCMPCommon` folder and move the `AtomicInterface` to the `include/mlir/interfaces`? 

https://github.com/llvm/llvm-project/pull/65493


More information about the Mlir-commits mailing list