[Mlir-commits] [mlir] [mlir][transform] Fix new interpreter and library preloading passes. (PR #69190)

[Ingo Müller]

ingomueller-net wrote:

> I see, thanks. What really escaped my attention here is that a pass cannot load a dialect because it run in multithreaded mode, so it has to declare as dependent any dialect it needed to load and have it loaded by the pass manager. This is different from creating entities from the dialect, which is impossible without the dialect being loaded in the first place. Not sure if this is documented sufficiently, somehow it wasn't obvious to me.

Thanks for the explanation! Those subtleties had escape *my* attention completely, so it's great to have them brought to my attention.

> > I don't think it was approved though, was it?
> 
> Indeed, it wasn't. I haven't requested changes as I was rather asking for clarification. Approved after-the-fact, but generally better to wait for approval in the future.

So sorry!! This wasn't on purpose -- I had assumed/thought that it was approved, which it wasn't. Will be more careful next time!

https://github.com/llvm/llvm-project/pull/69190