[Mlir-commits] [mlir] [mlir][VectorOps] Support string literals in `vector.print` (PR #68695)

Andrzej WarzyƄski llvmlistbot at llvm.org
Mon Oct 16 09:16:37 PDT 2023


================
@@ -2476,12 +2477,18 @@ def Vector_TransposeOp :
 }
 
 def Vector_PrintOp :
-  Vector_Op<"print", []>,
+  Vector_Op<"print", [
+    PredOpTrait<
+      "`source` or `punctuation` are not set when printing strings",
----------------
banach-space wrote:

Perhaps I am a bit pedantic, but this reads a bit off :) Perhaps "Strings mixed with `source` and `punctations` are not allowed/supported" ?

https://github.com/llvm/llvm-project/pull/68695


More information about the Mlir-commits mailing list