[Mlir-commits] [mlir] [mlir][ArmSME] Update tile slice layout syntax (PR #69151)

Andrzej WarzyƄski llvmlistbot at llvm.org
Mon Oct 16 02:50:42 PDT 2023


banach-space wrote:

> > the ambiguity comes from having 2 optional groups with leading ,, the generator can't handle this.
> 
> As when it sees a `,` it does not know if what follows should be the padding or the layout. It's not clever enough to look ahead and see the next token must be a layout (or must be padding), so it requires you to use the explicit syntax (`#arm_sme.layout<horizontal>`).

Ah, now it makes sense :)

[NIT] `<vertical> -> layout<vertical>` --> `, <vertical> -> layout<vertical>`

:)

https://github.com/llvm/llvm-project/pull/69151


More information about the Mlir-commits mailing list