[Mlir-commits] [mlir] [mlir] Fix use-after-free bugs in {RankedTensorType|VectorType}::Builder (PR #68969)

Cullen Rhodes llvmlistbot at llvm.org
Mon Oct 16 01:53:51 PDT 2023


================
@@ -277,7 +277,7 @@ class RankedTensorType::Builder {
     if (storage.empty())
       storage.append(shape.begin(), shape.end());
     storage.erase(storage.begin() + pos);
-    shape = {storage.data(), storage.size()};
+    shape = {};
----------------
c-rhodes wrote:

I think it would be good to have some tests for this, perhaps in `mlir/unittests/IR/ShapedTypeTest.cpp` 

https://github.com/llvm/llvm-project/pull/68969


More information about the Mlir-commits mailing list