[Mlir-commits] [mlir] [mlir] Fix use-after-free bugs in {RankedTensorType|VectorType}::Builder (PR #68969)
Benjamin Maxwell
llvmlistbot at llvm.org
Mon Oct 16 00:57:30 PDT 2023
================
@@ -277,7 +277,7 @@ class RankedTensorType::Builder {
if (storage.empty())
storage.append(shape.begin(), shape.end());
storage.erase(storage.begin() + pos);
- shape = {storage.data(), storage.size()};
+ shape = {};
----------------
MacDue wrote:
No, that's the bug. If you copy the builder and the first is destroyed you end up with array refs pointing at junk. The new getters prevent that.
https://github.com/llvm/llvm-project/pull/68969
More information about the Mlir-commits
mailing list