[Mlir-commits] [mlir] [mlir][affine] remove divide zero check when simplifer affineMap (#64622) (PR #68519)

[llvmlistbot at llvm.org]

lipracer wrote:

> I'm a bit hesitant to add a `LogicalResult` return value to the entire visitor logic here. It is not clear to me whether this operation should fold to a poison value in case of a division by zero. If that's not the case, we won't need the `LogicalResult` return value. Until that's clear, I would just go with a simpler fix: just stop folding when there's a division by zero, by treating it the same was as "not a constant".
Perhaps `mlir::WalkResult` is more suitable here, but it seems to be used to traverse ir.

https://github.com/llvm/llvm-project/pull/68519