[Mlir-commits] [mlir] [mlir][spirv][webgpu] Add lowering of IAddCarry to IAdd (PR #68495)

Jakub Kuderski llvmlistbot at llvm.org
Fri Oct 13 16:53:16 PDT 2023


kuhar wrote:

@inbelic I made the test type check and compile but it doesn't give the expected output: https://github.com/kuhar/llvm-project/commit/d20f576f89b6595549126fde8311a0c4bf93e104

I changed the i8 memrefs to i32 because the type of both iadd_carry results will be the same on the spir-v side anyway, and it doesn't require spir-v capabilities for i8 types. This extends out test coverage to vulkan implementations that don't expose these, e.g., swiftshader.

https://github.com/llvm/llvm-project/pull/68495


More information about the Mlir-commits mailing list