[Mlir-commits] [mlir] [OpenMP][Flang] Add "IsolatedFromAbove" trait to omp.target (PR #67164)

[llvmlistbot at llvm.org]

agozillon wrote:

> > > I have another question. Are these bounds required for the map operation, then shouldn't they be part of the `map_info` operation or the variable being mapped?
> > 
> > 
> > Yes, and MapInfoOps are currently being created for them.
> 
> If the bounds are really required for the map operation then shouldn't be captured as part of the `omp.map_info` operation. Can it not be captured by creating an `omp.bounds` operation that feeds into the `omp.map_info`? If not, can we add another entry to `omp.map_info` to capture this?

Perhaps I am misunderstanding what you mean (so my apologies if I am), but I believe this is already the case, map_info holds or is supposed to hold bounds information: https://github.com/llvm/llvm-project/blob/main/mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td#L1149. 

It is a little weird that we'd now end up creating a map_info for each bound which then has an empty bound though. I agree that it would be nice to not have to do that as it feels a bit like it defeats the purpose of a map_info owning a bound, but perhaps it's unavoidable.



https://github.com/llvm/llvm-project/pull/67164