[mlir] [mlir] Add support for vector types whose number of elements are from… (PR #68030)

Andrzej Warzyński llvmlistbot at llvm.org
Thu Oct 12 18:35:08 PDT 2023


banach-space wrote:

Perhaps I am missing something, but I don't see e.g. `ScalableVectorOfMinLengthRangeAndType` to be used in your other patch. And in general, does SPIR-V require scalable vectors?

> About the tests, This PR was part of a larger PR. The next part of this PR (https://github.com/llvm/llvm-project/pull/68034) has the tests that uses this constraint in SPIRV.

Does the other patch include tests for scalable vectors? 

Small PRs (like this one) are definitely preferable, but they should also be self-contained. That's not really the case here though - without tests or other code that would validate/use the new constraints, it's hard to tell whether that's what we need (or, indeed, whether we need it at all).

https://github.com/llvm/llvm-project/pull/68030


More information about the Mlir-commits mailing list