[Mlir-commits] [mlir] [mlir][sparse] implement sparse_tensor.reorder_coo (PR #68916)

Aart Bik llvmlistbot at llvm.org
Thu Oct 12 13:04:06 PDT 2023


================
@@ -349,6 +349,8 @@ class SparseTensorStorage final : public SparseTensorStorageBase {
 
   ~SparseTensorStorage() final = default;
 
+  void sortInPlace();
----------------
aartbik wrote:

can  you
(1) move this towards the end of all methods in public part (since we should have constructor/destructor/getters/setters and then other methods grouped by logic as order)
(2) add a comment

https://github.com/llvm/llvm-project/pull/68916


More information about the Mlir-commits mailing list