[Mlir-commits] [mlir] [mlir][arith] Fix canon pattern for large ints in chained arith (PR #68900)

Markus Böck llvmlistbot at llvm.org
Thu Oct 12 11:53:32 PDT 2023


https://github.com/zero9178 commented:

Thank you so much for tackling this! I only left some comments regarding some code details.

I also think that you should definitely keep the test. Given that this case used to assert, we seemingly didn't have any test coverage for larger than 64 bit integers, which is why having the test is definitely valuable.

https://github.com/llvm/llvm-project/pull/68900


More information about the Mlir-commits mailing list