[Mlir-commits] [mlir] [mlir][ODS] Add `OptionalTypesMatchWith` and remove a custom assemblyFormat (PR #68876)

Benjamin Maxwell llvmlistbot at llvm.org
Thu Oct 12 07:31:17 PDT 2023


================
@@ -263,9 +265,8 @@ def Vector_ReductionOp :
                          "::mlir::arith::FastMathFlags::none">:$fastMathFlags)>
   ];
 
-  // TODO: Migrate to assemblyFormat once `AllTypesMatch` supports optional
-  // operands.
-  let hasCustomAssemblyFormat = 1;
+  let assemblyFormat = "$kind `,` $vector (`,` $acc^)? (`fastmath` $fastmath^)?"
----------------
MacDue wrote:

Ah! Thanks! Good to know :smile: 

https://github.com/llvm/llvm-project/pull/68876


More information about the Mlir-commits mailing list