[Mlir-commits] [mlir] [OpenMP][Flang] Add "IsolatedFromAbove" trait to omp.target (PR #67164)

[Kiran Chandramohan]

kiranchandramohan wrote:

> Perhaps a silly question, but is it required that the bounds be added to the map operands as implicit maps? would it be possible for these to be just block arguments? 

I had the same question as @agozillon when I first went over the patch. But he beat me to it. :)

I have another question. Are these bounds required for the map operation, then shouldn't they be part of the `map_info` operation or the variable being mapped?

Regarding the change you made, it does not look correct to have the `varPtr` field accepting an `index` value. Also for mapping, you would only map pointers or memory locations and not values.

> I don't know if there are existing optimisations in MLIR that remove unused block_args, should be fairly straightforward to add one.

There is a pass to remove dead values and it is advertised as working for region arguments. Not sure whether it handles entry block arguments.
https://reviews.llvm.org/rG0e98fb9fadb056e90f2649601914942765d7bf09

https://github.com/llvm/llvm-project/pull/67164