[Mlir-commits] [mlir] [mlir][ArmSVE] Add convert_to/from_svbool ops (PR #68586)

[Andrzej Warzyński]

================
@@ -404,6 +417,12 @@ class ScalableVectorOf<list<Type> allowedTypes> :
   ShapedContainerType<allowedTypes, IsScalableVectorTypePred,
           "scalable vector", "::mlir::VectorType">;
 
+// Any vector with a single trailing scalable dimension, with an element type in
+// the `allowedTypes` list.
+class TrailingScalableVectorOf<list<Type> allowedTypes> :
----------------
banach-space wrote:

Naming is hard, but how about:
* `VectorWithTrailingDimScalableOf`, or 
* `ScalableVectorWithOnlyTrailingDimScalableOf`?

I'm just not a fan of `TrailingScalableVector` - that's a bit ambiguous to me :) Things could be easier if we didn't add "Of" at the end, but that would require updating existing vector types 😢 .

[nit] Also, in your comment you could contrast it with `ScalableVectorOf`:
> Similar to ScalableVectorOf, with the extra requirement that only the trailing dim is  scalable.

I find such comments really helpful when identifying the "right tool for the job" :) 

https://github.com/llvm/llvm-project/pull/68586