[Mlir-commits] [mlir] [mlir][python] Improve sanitization of python names (PR #68801)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Wed Oct 11 06:04:14 PDT 2023
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff 27ecb63c260400dd20b8c5dc16d0dfd2d0e7122e e6195ac4b5cbe12920195df7a3a544d41c838d49 -- mlir/tools/mlir-tblgen/OpPythonBindingGen.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/mlir/tools/mlir-tblgen/OpPythonBindingGen.cpp b/mlir/tools/mlir-tblgen/OpPythonBindingGen.cpp
index 0652e9194..996cdf53a 100644
--- a/mlir/tools/mlir-tblgen/OpPythonBindingGen.cpp
+++ b/mlir/tools/mlir-tblgen/OpPythonBindingGen.cpp
@@ -1012,15 +1012,14 @@ static void emitValueBuilder(const Operator &op,
});
auto name_without_dialect =
op.getOperationName().substr(op.getOperationName().find('.') + 1);
- os << llvm::formatv(
- valueBuilderTemplate,
- sanitizeName(name_without_dialect),
- op.getCppClassName(), llvm::join(valueBuilderParams, ", "),
- llvm::join(opBuilderArgs, ", "),
- (op.getNumResults() > 1
- ? "_Sequence[_ods_ir.OpResult]"
- : (op.getNumResults() > 0 ? "_ods_ir.OpResult"
- : "_ods_ir.Operation")));
+ os << llvm::formatv(valueBuilderTemplate, sanitizeName(name_without_dialect),
+ op.getCppClassName(),
+ llvm::join(valueBuilderParams, ", "),
+ llvm::join(opBuilderArgs, ", "),
+ (op.getNumResults() > 1
+ ? "_Sequence[_ods_ir.OpResult]"
+ : (op.getNumResults() > 0 ? "_ods_ir.OpResult"
+ : "_ods_ir.Operation")));
}
/// Emits bindings for a specific Op to the given output stream.
``````````
</details>
https://github.com/llvm/llvm-project/pull/68801
More information about the Mlir-commits
mailing list