[Mlir-commits] [mlir] [OpenMP][Flang] Add "IsolatedFromAbove" trait to omp.target (PR #67164)

[llvmlistbot at llvm.org]

agozillon wrote:

> I have updated the patch to add all `bounds` and `extents` related to `box` values as `implicit` `map_operands` as well as `block_arguments`.
> 
> They type for `map_operands` and `map_info` entries/results have been changed to `AnyType` from `OpenMP_PointerLikeType` in OpenMPOps. This is to allow addition of `index` types(from bounds/extents) to `map_operands`.
> 
> Also added the test from @jeanPerier to both FIR and HLFIR.
> 
> Let me know if there are any suggestions, and thanks again @jeanPerier and @kiranchandramohan for helping identify and solve the issues.

Perhaps a silly question, but is it required that the bounds be added to the map operands as implicit maps? would it be possible for these to be just block arguments? At least at the moment, for the tests I've done, the bounds do not get mapped across to the device, but perhaps that changes with the new changes to support IsolatedFromAbove (or one of the newly covered test cases)? 

My main thought and it could be incorrect, is if they're not being used in the target itself and being transferred to device then it occludes the other things that are being mapped and also makes discerning the appropriate things to map in the lowering more difficult

https://github.com/llvm/llvm-project/pull/67164