[Mlir-commits] [mlir] [mlir][ArmSVE] Add convert_to/from_svbool ops (PR #68586)

[Benjamin Maxwell]

================
@@ -37,6 +37,12 @@ def IsFixedVectorTypePred : CPred<[{::llvm::isa<::mlir::VectorType>($_self) &&
 def IsScalableVectorTypePred : CPred<[{::llvm::isa<::mlir::VectorType>($_self) &&
                                    ::llvm::cast<VectorType>($_self).isScalable()}]>;
 
+// Whether a type is a scalable VectorType, with a single trailing scalable dimension.
+def IsTrailingScalableVectorTypePred : And<[CPred<"::llvm::isa<::mlir::VectorType>($_self)">,
----------------
MacDue wrote:

You don't actually get anything from `IsScalableVectorTypePred`. That just checks if you have a scalable dim _anywhere_, so you still have to check that the trailing dim is scalable, and that all the other dims are not.  

It's a refined version of `IsVectorTypePred`, but as that'll remove `getRank() > 0` at some point in the future, that can't be depended on. 

https://github.com/llvm/llvm-project/pull/68586