[Mlir-commits] [mlir] [NFC][FuncOpToLLVM] refactor and move some utils to headers (PR #68665)

Mehdi Amini llvmlistbot at llvm.org
Tue Oct 10 00:04:41 PDT 2023


================
@@ -14,13 +14,28 @@
 #ifndef MLIR_CONVERSION_FUNCTOLLVM_CONVERTFUNCTOLLVM_H
 #define MLIR_CONVERSION_FUNCTOLLVM_CONVERTFUNCTOLLVM_H
 
+#include "mlir/Interfaces/FunctionInterfaces.h"
+#include "mlir/Support/LogicalResult.h"
+
 namespace mlir {
 
+namespace LLVM {
+class LLVMFuncOp;
+} // namespace LLVM
+
+class ConversionPatternRewriter;
 class DialectRegistry;
 class LLVMTypeConverter;
 class RewritePatternSet;
 class SymbolTable;
 
+/// Convert input FuncOp to LLVMFuncOp by using the provided LLVMTypeConverter.
+/// Returns failure if failed to so.
----------------
joker-eph wrote:

```suggestion
/// Convert input FunctionOpInterface operation to LLVMFuncOp by using the
/// provided LLVMTypeConverter. Return failure if failed to so.
```

https://github.com/llvm/llvm-project/pull/68665


More information about the Mlir-commits mailing list