[Mlir-commits] [mlir] Update MLIR conversion to LLVMFunc to account better for properties (PR #67406)

[Tobias Gysi]

================
@@ -40,6 +40,7 @@ module {
       arg_attrs = [{llvm.noalias}, {}], xxx = {yyy = 42}} : () -> ()
 
   // CHECK: llvm.func @roundtrip1()
+  // CHECK-GENERIC: "llvm.func"{{.*}}@roundtrip1{{.*}}visibility = "private"
----------------
gysit wrote:

I am a bit surprised the visibility is private here since I would expect the new funcOp argument is an optional attribute and not a default valued attribute? But it seems to pass tests so I have to miss something :).

https://github.com/llvm/llvm-project/pull/67406