[Mlir-commits] [mlir] [mlir][linalg] Enable CollapseLinalgDimensions to collapse linalg::CopyOp (PR #68526)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Sun Oct 8 09:00:21 PDT 2023
https://github.com/MaheshRavishankar requested changes to this pull request.
Overall change looks reasonable. Some refactoring might make this better, but this throws up some design issues. Why is `CopyOp` treated specially? This should work for other Linalg named ops as well. An alternative would be to use matchers to match a `linalg.generic` and convert to a `linalg.copy` after it is collapsed. That way we could keep the two concerns separate (and having a matcher for `linalg.generic` -> `linalg.copy` might be helpful in other places as well.
https://github.com/llvm/llvm-project/pull/68526
More information about the Mlir-commits
mailing list