[Mlir-commits] [mlir] [mlir][tosa] Add verifier for `ArgMax` operator (PR #68410)

Eric Kunze llvmlistbot at llvm.org
Fri Oct 6 16:48:43 PDT 2023


eric-k256 wrote:

I think checking the axis in the verifier is a good idea. For the size check, I know that the current spec calls out i32 as the return type, but anticipating future changes where that is changed to a larger number, this feels like something that should go into the opt-in pass that takes a profile to validate against. That profile check would fail today, but implementations that don't strictly check can still use the operator set.

https://github.com/llvm/llvm-project/pull/68410


More information about the Mlir-commits mailing list