[Mlir-commits] [mlir] [mlir][sparse] removed unused using clauses in support lib (PR #68148)

[Aart Bik]

https://github.com/aartbik updated https://github.com/llvm/llvm-project/pull/68148

>From 0e70df3fbceb391925e88af61ded95a7cb68658a Mon Sep 17 00:00:00 2001
From: Aart Bik <ajcbik at google.com>
Date: Tue, 3 Oct 2023 11:56:37 -0700
Subject: [PATCH 1/2] [mlir][sparse] removed unused using clauses in support
 lib

---
 mlir/include/mlir/ExecutionEngine/SparseTensor/COO.h | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/mlir/include/mlir/ExecutionEngine/SparseTensor/COO.h b/mlir/include/mlir/ExecutionEngine/SparseTensor/COO.h
index bbe8396af15f3a6..bfe8b3729f384d7 100644
--- a/mlir/include/mlir/ExecutionEngine/SparseTensor/COO.h
+++ b/mlir/include/mlir/ExecutionEngine/SparseTensor/COO.h
@@ -71,14 +71,7 @@ using ElementConsumer =
 template <typename V>
 class SparseTensorCOO final {
 public:
-  using value_type = const Element<V>;
-  using reference = value_type &;
-  using const_reference = reference;
-  using vector_type = std::vector<Element<V>>;
-  using iterator = typename vector_type::const_iterator;
-  using const_iterator = iterator;
-  using difference_type = typename vector_type::difference_type;
-  using size_type = typename vector_type::size_type;
+  using const_iterator = std::vector<Element<V>>::const_iterator;
 
   /// Constructs a new coordinate-scheme sparse tensor with the given
   /// sizes and an optional initial storage capacity.

>From 484e0a9c51047d866967c35cbadad3f83f695e54 Mon Sep 17 00:00:00 2001
From: Aart Bik <ajcbik at google.com>
Date: Tue, 3 Oct 2023 12:01:49 -0700
Subject: [PATCH 2/2] typename

---
 mlir/include/mlir/ExecutionEngine/SparseTensor/COO.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mlir/include/mlir/ExecutionEngine/SparseTensor/COO.h b/mlir/include/mlir/ExecutionEngine/SparseTensor/COO.h
index bfe8b3729f384d7..f6eb45defcc1cfd 100644
--- a/mlir/include/mlir/ExecutionEngine/SparseTensor/COO.h
+++ b/mlir/include/mlir/ExecutionEngine/SparseTensor/COO.h
@@ -71,7 +71,7 @@ using ElementConsumer =
 template <typename V>
 class SparseTensorCOO final {
 public:
-  using const_iterator = std::vector<Element<V>>::const_iterator;
+  using const_iterator = typename std::vector<Element<V>>::const_iterator;
 
   /// Constructs a new coordinate-scheme sparse tensor with the given
   /// sizes and an optional initial storage capacity.