[Mlir-commits] [mlir] [OpenMP][OpenMPIRBuilder][NFC] Move copyInput to a passed in lambda function (PR #68124)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Tue Oct 3 10:47:51 PDT 2023


================
@@ -5301,6 +5319,23 @@ TEST_F(OpenMPIRBuilderTest, TargetRegionDevice) {
       Constant::getNullValue(PointerType::get(Ctx, 0)),
       Constant::getNullValue(PointerType::get(Ctx, 0))};
 
+  auto SimpleArgAccessorCB = [&](llvm::Argument &Arg, llvm::Value *Input,
+                                 IRBuilderBase &Builder) {
----------------
shraiysh wrote:

I don't think differing IRs is a problem as long as they are correct. I have not worked much on target side, so I am okay with the current implementation and would also be okay with adding an IP, whatever works best.

https://github.com/llvm/llvm-project/pull/68124


More information about the Mlir-commits mailing list