[Mlir-commits] [mlir] [mlir][transform] Make variable names in interpreter consistent. (NFC) (PR #67800)

Ingo Müller llvmlistbot at llvm.org
Tue Oct 3 07:44:32 PDT 2023


================
@@ -379,14 +379,20 @@ static LogicalResult defineDeclaredSymbols(Block &block, ModuleOp definitions) {
 LogicalResult transform::detail::interpreterBaseRunOnOperationImpl(
     Operation *target, StringRef passName,
     const std::shared_ptr<OwningOpRef<ModuleOp>> &sharedTransformModule,
-    const std::shared_ptr<OwningOpRef<ModuleOp>> &libraryModule,
+    const std::shared_ptr<OwningOpRef<ModuleOp>> &transformLibraryModule,
----------------
ingomueller-net wrote:

I could rename that as well, but I guess it would also make sense to rename the corresponding accessor (`getTransformLibraryModule`) and renaming *that* would make the PR non-NFC. Preferences?

https://github.com/llvm/llvm-project/pull/67800


More information about the Mlir-commits mailing list