[Mlir-commits] [mlir] c1c56ae - Remove `let constructor =` from ArithBufferizePass and rely on TableGen to generate the glue (NFC)
Mehdi Amini
llvmlistbot at llvm.org
Mon Oct 2 15:41:26 PDT 2023
Author: Mehdi Amini
Date: 2023-10-02T15:41:16-07:00
New Revision: c1c56ae49e57b593cbd6cefba48cd471951d10ea
URL: https://github.com/llvm/llvm-project/commit/c1c56ae49e57b593cbd6cefba48cd471951d10ea
DIFF: https://github.com/llvm/llvm-project/commit/c1c56ae49e57b593cbd6cefba48cd471951d10ea.diff
LOG: Remove `let constructor =` from ArithBufferizePass and rely on TableGen to generate the glue (NFC)
Added:
Modified:
mlir/include/mlir/Dialect/Arith/Transforms/Passes.h
mlir/include/mlir/Dialect/Arith/Transforms/Passes.td
mlir/lib/Dialect/Arith/Transforms/Bufferize.cpp
Removed:
################################################################################
diff --git a/mlir/include/mlir/Dialect/Arith/Transforms/Passes.h b/mlir/include/mlir/Dialect/Arith/Transforms/Passes.h
index 2c2353bdc810274..a8c69f900a0e813 100644
--- a/mlir/include/mlir/Dialect/Arith/Transforms/Passes.h
+++ b/mlir/include/mlir/Dialect/Arith/Transforms/Passes.h
@@ -20,15 +20,10 @@ namespace arith {
#define GEN_PASS_DECL
#include "mlir/Dialect/Arith/Transforms/Passes.h.inc"
-#define GEN_PASS_DECL_ARITHINTRANGEOPTS
-#include "mlir/Dialect/Arith/Transforms/Passes.h.inc"
class WideIntEmulationConverter;
class NarrowTypeEmulationConverter;
-/// Create a pass to bufferize Arith ops.
-std::unique_ptr<Pass> createArithBufferizePass();
-
/// Create a pass to bufferize arith.constant ops.
std::unique_ptr<Pass> createConstantBufferizePass(uint64_t alignment = 0);
diff --git a/mlir/include/mlir/Dialect/Arith/Transforms/Passes.td b/mlir/include/mlir/Dialect/Arith/Transforms/Passes.td
index 77575b0b5a57df9..6b7bbd2b2b1094f 100644
--- a/mlir/include/mlir/Dialect/Arith/Transforms/Passes.td
+++ b/mlir/include/mlir/Dialect/Arith/Transforms/Passes.td
@@ -21,7 +21,6 @@ def ArithBufferize : Pass<"arith-bufferize", "ModuleOp"> {
multi-threading. Most other bufferization passes can run in parallel at
function granularity.
}];
- let constructor = "mlir::arith::createArithBufferizePass()";
let options = [
Option<"alignment", "alignment", "unsigned", /*default=*/"0",
"Create global memrefs with a specified alignment">,
diff --git a/mlir/lib/Dialect/Arith/Transforms/Bufferize.cpp b/mlir/lib/Dialect/Arith/Transforms/Bufferize.cpp
index f2a0f45acad6f9e..4dbfe5b61022e2a 100644
--- a/mlir/lib/Dialect/Arith/Transforms/Bufferize.cpp
+++ b/mlir/lib/Dialect/Arith/Transforms/Bufferize.cpp
@@ -29,6 +29,8 @@ namespace {
/// Pass to bufferize Arith ops.
struct ArithBufferizePass
: public arith::impl::ArithBufferizeBase<ArithBufferizePass> {
+ using arith::impl::ArithBufferizeBase<ArithBufferizePass>::ArithBufferizeBase;
+
ArithBufferizePass(uint64_t alignment = 0, bool constantOpOnly = false)
: constantOpOnly(constantOpOnly) {
this->alignment = alignment;
@@ -58,10 +60,6 @@ struct ArithBufferizePass
};
} // namespace
-std::unique_ptr<Pass> mlir::arith::createArithBufferizePass() {
- return std::make_unique<ArithBufferizePass>();
-}
-
std::unique_ptr<Pass>
mlir::arith::createConstantBufferizePass(uint64_t alignment) {
return std::make_unique<ArithBufferizePass>(alignment,
More information about the Mlir-commits
mailing list