[Mlir-commits] [mlir] [MLIR][Presburger] Preserve identifiers in IntegerRelation::convertVa… (PR #67909)

[Kunwar Grover]

================
@@ -1325,6 +1325,10 @@ void IntegerRelation::convertVarKind(VarKind srcKind, unsigned varStart,
   if (varStart >= varLimit)
     return;
 
+  // Save the space as the insert/delete vars operations affect the identifier
+  // information in the space.
+  PresburgerSpace oldSpace = space;
+
----------------
Groverkss wrote:

Not the biggest fan of this solution. A better solution according to me is implementing a moveRows function in Matrix, calculating what offsets to move and calling moveRows here, and then just calling convertVarKind on the space.

https://github.com/llvm/llvm-project/pull/67909