[Mlir-commits] [mlir] [mlir][memref] Use array notation instead of permutation map for memref.transpose (PR #67880)

[Oleksandr Alex Zinenko]

https://github.com/ftynse requested changes to this pull request.

I don't think it is an improvement for understandability of the IR. With an array, there are always two ways to interpret it: (1) `pos`-th number in the array indicates the new place of the current `pos`-th dimension or (2) `pos`-th number in the array indicates the current location of the dimension that will end up in `pos`-th position after permutation. Some people may be used to one or another, but I have seen interpretations being used. So now I systematically have to check which of the interpretations is correct in the documentation. A permutation map, on the other hand, has no such ambiguity by design.

https://github.com/llvm/llvm-project/pull/67880