[Mlir-commits] [mlir] [mlir] Add support for DIGlobalVariable and DIGlobalVariableExpression (PR #73367)

[Tobias Gysi]

================
@@ -447,6 +468,40 @@ def LLVM_DILocalVariableAttr : LLVM_Attr<"DILocalVariable", "di_local_variable",
   let assemblyFormat = "`<` struct(params) `>`";
 }
 
+//===----------------------------------------------------------------------===//
+// DIGlobalVariableExpressionAttr
+//===----------------------------------------------------------------------===//
+
+def LLVM_DIGlobalVariableExpressionAttr
+    : LLVM_Attr<"DIGlobalVariableExpression", "di_global_variable_expression",
+                /*traits=*/[], "DINodeAttr"> {
----------------
gysit wrote:

```suggestion
                > {
```
If we follow the LLVM class diagram we could skip the base class here?

https://github.com/llvm/llvm-project/pull/73367