[Mlir-commits] [mlir] [mlir] Add support for DIGlobalVariable and DIGlobalVariableExpression (PR #73367)
Tobias Gysi
llvmlistbot at llvm.org
Thu Nov 30 23:46:52 PST 2023
================
@@ -43,8 +55,9 @@ void LLVMDialect::registerAttributes() {
bool DINodeAttr::classof(Attribute attr) {
return llvm::isa<DIBasicTypeAttr, DICompileUnitAttr, DICompositeTypeAttr,
- DIDerivedTypeAttr, DIFileAttr, DILabelAttr,
- DILexicalBlockAttr, DILexicalBlockFileAttr,
+ DIDerivedTypeAttr, DIExpressionAttr, DIFileAttr,
+ DIGlobalVariableAttr, DIGlobalVariableExpressionAttr,
+ DILabelAttr, DILexicalBlockAttr, DILexicalBlockFileAttr,
----------------
gysit wrote:
```suggestion
DIDerivedTypeAttr, DIFileAttr,
DIGlobalVariableAttr,
DILabelAttr, DILexicalBlockAttr, DILexicalBlockFileAttr,
```
If the attributes do not derive from DINode anymore, following the LLVM class diagram, we can remove them here.
https://github.com/llvm/llvm-project/pull/73367
More information about the Mlir-commits
mailing list