[Mlir-commits] [mlir] [mlir][vector] Make `TransposeOpLowering` configurable (PR #73915)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Thu Nov 30 16:43:33 PST 2023
MaheshRavishankar wrote:
> > What we have is basically a vector lowering that introduces shape_cast irrespective of the backend being used, without it being supported on all backends. Thats seems like a bad situation to be in.
>
> Sure, let's fix the incomplete backend. Let's note though that most of MLIR dialects and passes are "in development" and so the fact that a backend is incomplete at any given point is pretty high: "a bad situation to be in" is just the full state of MLIR dialects upstream...
Absolutely! No judgement here. Lot of us contribute/maintain lot of these backends (especially SPIR-V). Should try to fix the incomplete backend, but we should not make things that hit this part of the default flow that downstream users cannot opt-out of right? I have no idea how much work it is to finish this on SPIR-V side. It seems reasonable to me to co-ordinate and fix the incompleteness in the backends before adding something that is always on.
https://github.com/llvm/llvm-project/pull/73915
More information about the Mlir-commits
mailing list