[Mlir-commits] [mlir] [mlir][vector] Make `TransposeOpLowering` configurable (PR #73915)
Benjamin Maxwell
llvmlistbot at llvm.org
Thu Nov 30 03:00:02 PST 2023
MacDue wrote:
> I think the source of the problem is that SPIRV-V can't currently handle shape_cast in general, regardless of where it's coming from. Nicolas pointed at the shape cast [lowering patterns](https://github.com/llvm/llvm-project/blob/437a48b2d9bfc6e38a0ca43f1cee48ceaf0fe249/mlir/lib/Dialect/Vector/Transforms/LowerVectorShapeCast.cpp#L354-L359) that we use for LLVM and mentioned that they should also work for SPIR-V. Maybe we could give that a try?
Yes, but the suggested fold is not adding a new `shape_cast`, it's just updating a pre-existing one, so if SPIR-V so won't effect SPIR-V as there never will be a `transpose(shape_cast)` in their lowerings.
https://github.com/llvm/llvm-project/pull/73915
More information about the Mlir-commits
mailing list