[Mlir-commits] [mlir] [mlir][Vector] Add a rewrite pattern for gather over a strided memref (PR #72991)
Andrzej WarzyĆski
llvmlistbot at llvm.org
Thu Nov 30 01:04:34 PST 2023
================
@@ -168,6 +244,6 @@ struct Gather1DToConditionalLoads : OpRewritePattern<vector::GatherOp> {
void mlir::vector::populateVectorGatherLoweringPatterns(
RewritePatternSet &patterns, PatternBenefit benefit) {
- patterns.add<FlattenGather, Gather1DToConditionalLoads>(patterns.getContext(),
- benefit);
+ patterns.add<FlattenGather, RemoveStrideFromGatherSource,
----------------
banach-space wrote:
Yup, this is why I have restricted `Gather1DToConditionalLoads` here:
* https://github.com/llvm/llvm-project/pull/72991/commits/7d9f17c6b1a0cf77c06f89b9d4ae60bfee08ad4d
The other pattern in this file, `FlattenGather`, should be OK as is (I wasn't able to make it crash).
https://github.com/llvm/llvm-project/pull/72991
More information about the Mlir-commits
mailing list