[Mlir-commits] [mlir] [mlir][vector] Add patterns to simplify chained reductions (PR #73048)
Diego Caballero
llvmlistbot at llvm.org
Wed Nov 29 16:14:29 PST 2023
dcaballe wrote:
Thanks for adding this. I think it's very useful! Have you looked at what split reduction does? I haven't found a case where these chains happens when split reduction is used. We only generate one reduction at the very end. Also wondering if we should enable this only for more aggressive fp modes (I think we have a "fp reassociation" flag in IREE) as the transformation is changing the order in which elements are reduced. I use to fall back to this trivial chain of reductions when debugging numerical issues because they preserve the scalar execution order to some extent.
https://github.com/llvm/llvm-project/pull/73048
More information about the Mlir-commits
mailing list