[Mlir-commits] [mlir] [mlir][linalg] do not break outs from block argument (PR #73572)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Tue Nov 28 20:35:50 PST 2023
MaheshRavishankar wrote:
Ok, there is a lot of things here being discussed. I filed an issue with a bit more details https://github.com/llvm/llvm-project/issues/73745 . Maybe we can continue broader discussion over there.
Overall though, I'd prefer to keep IREE "concepts" out of upstream discussion. The choice of what IREE does is specific to IREE. It can make its own assumptions and "priors". So bringing IREE concepts as is muddles the discussion a bit.
The real issue here is that this pattern is being too aggressive and not respecting destination passing style. Real fix is to address the issue above and actually make it respect destination passing style. The fix here is actually very temporary and happens to work for the particular case that @okkwon is looking at, but the real fix is described in the issue above.
https://github.com/llvm/llvm-project/pull/73572
More information about the Mlir-commits
mailing list