[Mlir-commits] [mlir] Reland "[mlir] Fix TileUsingForOp attr-dict printing/parsing" (PR #73261)
Maksim Levental
llvmlistbot at llvm.org
Tue Nov 28 11:23:42 PST 2023
================
@@ -355,7 +355,7 @@ def testTileCompact(target):
@create_sequence
def testTileAttributes(target):
attr = DenseI64ArrayAttr.get([4, 8])
- ichange = DenseI64ArrayAttr.get([0, 1])
+ ichange = Attribute.parse("[0, 1]")
----------------
makslevental wrote:
I'm of the opinion that tests that exercise code, even if the tests themselves are out of date (in terms of idioms and such), should be kept. Like I said - I just hadn't noticed the overlapping tests.
https://github.com/llvm/llvm-project/pull/73261
More information about the Mlir-commits
mailing list