[Mlir-commits] [mlir] [mlir] Add support for DIGlobalVariable and DIGlobalVariableExpression (PR #73367)
Justin Wilson
llvmlistbot at llvm.org
Tue Nov 28 07:09:17 PST 2023
================
@@ -281,6 +291,29 @@ llvm::DILocation *DebugTranslation::translateLoc(Location loc,
return translateLoc(loc, scope, /*inlinedAt=*/nullptr);
}
+// Translate the given DWARF expression metadata to to LLVM.
+llvm::DIExpression *
+DebugTranslation::translateExpression(LLVM::DIExpressionAttr attr) {
+ if (attr) {
----------------
waj334 wrote:
I can also just rewrite is as:
```
DebugTranslation::translateExpression(LLVM::DIExpressionAttr attr) {
SmallVector<uint64_t, 1> ops;
if (attr) {
// Append operations their operands to the list
for (const auto &op : attr.getOperations()) {
ops.push_back(op.getOpcode());
append_range(ops, op.getArguments());
}
}
return llvm::DIExpression::get(llvmCtx, ops);
}
```
https://github.com/llvm/llvm-project/pull/73367
More information about the Mlir-commits
mailing list