[Mlir-commits] [mlir] Revert "[mlir] Fix a warning" (PR #73640)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Tue Nov 28 04:20:10 PST 2023


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-mlir-core

@llvm/pr-subscribers-mlir

Author: Alexander Batashev (alexbatashev)

<details>
<summary>Changes</summary>

Revert patch 6318dd82732c583fcfa12fe5b8d837e048dbb571 "[mlir] Fix a warning"

Template ID is not allowed in destructor names starting with C++ 20: https://eel.is/c++draft/diff.cpp17.class#<!-- -->2

---
Full diff: https://github.com/llvm/llvm-project/pull/73640.diff


1 Files Affected:

- (modified) mlir/lib/Pass/PassRegistry.cpp (+1-1) 


``````````diff
diff --git a/mlir/lib/Pass/PassRegistry.cpp b/mlir/lib/Pass/PassRegistry.cpp
index b0c314369190a40..35ac4b8fd280eab 100644
--- a/mlir/lib/Pass/PassRegistry.cpp
+++ b/mlir/lib/Pass/PassRegistry.cpp
@@ -373,7 +373,7 @@ llvm::cl::OptionValue<OpPassManager>::operator=(
   return *this;
 }
 
-llvm::cl::OptionValue<OpPassManager>::~OptionValue<OpPassManager>() = default;
+llvm::cl::OptionValue<OpPassManager>::~OptionValue() = default;
 
 void llvm::cl::OptionValue<OpPassManager>::setValue(
     const OpPassManager &newValue) {

``````````

</details>


https://github.com/llvm/llvm-project/pull/73640


More information about the Mlir-commits mailing list