[Mlir-commits] [mlir] [mlir] Add support for DIGlobalVariable and DIGlobalVariableExpression (PR #73367)

[Christian Ulmann]

================
@@ -61,7 +61,11 @@ DICompositeTypeAttr DebugImporter::translateImpl(llvm::DICompositeType *node) {
   SmallVector<DINodeAttr> elements;
   for (llvm::DINode *element : node->getElements()) {
     assert(element && "expected a non-null element type");
-    elements.push_back(translate(element));
+    const auto translatedElement = translate(element);
+    if (translatedElement) {
+      // TODO: Should this fail if the returned attribute is invalid?
----------------
Dinistro wrote:

I would suggest to fail in such a case. Explicit failures help to detect bugs while implicit failures might be very hard to track down.

https://github.com/llvm/llvm-project/pull/73367