[Mlir-commits] [mlir] [mlir][ArmSME] Switch to an attribute-based tile allocation scheme (PR #73253)

Benjamin Maxwell llvmlistbot at llvm.org
Mon Nov 27 02:55:17 PST 2023


================
@@ -506,6 +496,7 @@ struct TileVectorPrintOpConversion : public OpRewritePattern<vector::PrintOp> {
       rewriter.setInsertionPointToStart(forOp.getBody());
       // Extract the current row from the tile.
       Value rowIndex = forOp.getInductionVar();
+      // FIXME: Forward tile IDs.
----------------
MacDue wrote:

Which is how other similar tile ops are lowered (e.g. vector.splat, vector.broadcast, etc). Using an interface allows setting/getting the tile IDs via methods (and validating them), it also avoids possible conflicts with other dialects (and prevents the IR from getting very messy. 

https://github.com/llvm/llvm-project/pull/73253


More information about the Mlir-commits mailing list