[Mlir-commits] [mlir] [mlir] Add support for DIGlobalVariable and DIGlobalVariableExpression (PR #73367)

[Tobias Gysi]

https://github.com/gysit commented:

Direction looks good to me!

Can you do a formatting / cleanup pass and then re request review so that I can do an in-depth review? I think there is some rebase issue since some type converter things show up in the revision. Also note that tablegen requires hand formatting (i.e., the code should not use more than 80 columns and an indention of 2 spaces). 

I would also remove the MDNode base class and introduce a translateExpr and translateGlobalExpr function. But let's see maybe other reviewers have different preferences there.

https://github.com/llvm/llvm-project/pull/73367