[Mlir-commits] [mlir] [mlir] Add support for DIGlobalVariable and DIGlobalVariableExpression (PR #73367)

[Justin Wilson]

================
@@ -23,15 +23,24 @@
 namespace mlir {
 namespace LLVM {
 
-/// This class represents the base attribute for all debug info attributes.
-class DINodeAttr : public Attribute {
+/// This class represents the base attribute for all metadata attributes.
+class MDNodeAttr : public Attribute {
----------------
waj334 wrote:

If the priority isn't having a single public API call to translate all things MDNode/DINode then I'll revert back to the way it was as this doesn't impact my implementation whatsoever. It was convenient that translate() already handled most of the things and I just did the work to take it the extra mile to handle more of them.

https://github.com/llvm/llvm-project/pull/73367