[Mlir-commits] [mlir] [mlir] Add support for DIGlobalVariable and DIGlobalVariableExpression (PR #73367)

[Tobias Gysi]

================
@@ -23,15 +23,24 @@
 namespace mlir {
 namespace LLVM {
 
-/// This class represents the base attribute for all debug info attributes.
-class DINodeAttr : public Attribute {
+/// This class represents the base attribute for all metadata attributes.
+class MDNodeAttr : public Attribute {
----------------
gysit wrote:

Ah I see, MDNode sounds like it is any metadata node? It feels like Attribute is the direct counterpart for it in MLIR (and we probably don't want to replicate it)? DILocation, which also derives from MDNode, is translated with a separate function in the debug info translation so maybe this would be the right approach for DIGlobalVariableExpression and DIExpression?

https://github.com/llvm/llvm-project/pull/73367