[Mlir-commits] [mlir] [mlir] Add support for DIGlobalVariable and DIGlobalVariableExpression (PR #73367)

[Tobias Gysi]

================
@@ -23,15 +23,24 @@
 namespace mlir {
 namespace LLVM {
 
-/// This class represents the base attribute for all debug info attributes.
-class DINodeAttr : public Attribute {
+/// This class represents the base attribute for all metadata attributes.
+class MDNodeAttr : public Attribute {
----------------
gysit wrote:

Can you explain why this new base class is necessary? It seems like the newly introduced attributes are also debug info attributes and I would expect they are derived from DINodeAttr.

https://github.com/llvm/llvm-project/pull/73367