[Mlir-commits] [mlir] [mlir] Add support for DIGlobalVariable and DIGlobalVariableExpression (PR #73367)

[Justin Wilson]

================
@@ -455,7 +456,7 @@ def LLVM_DbgDeclareOp : LLVM_DbgIntrOp<"dbg.declare", "addr",
   let arguments = (ins
     LLVM_AnyPointer:$addr,
     LLVM_DILocalVariableAttr:$varInfo,
-    DefaultValuedAttr<LLVM_DIExpressionAttr, "std::nullopt">:$locationExpr
+    OptionalAttr<LLVM_DIExpressionAttr>:$locationExpr
----------------
waj334 wrote:

```
void GlobalOp::populateDefaultProperties(::mlir::OperationName opName, Properties &properties) {
  ::mlir::Builder odsBuilder(opName.getContext());
  // template is: $_builder.getIntegerAttr($_builder.getIntegerType(32), $0)
  // default is: 0
  if (!properties.addr_space)
    properties.addr_space = odsBuilder.getIntegerAttr(odsBuilder.getIntegerType(32), 0);
  // template is: 
  // default is: ::mlir::LLVM::DIGlobalVariableExpressionAttr()
  if (!properties.dbg_expr)
    properties.dbg_expr = ;
  // template is: ::mlir::LLVM::VisibilityAttr::get($_builder.getContext(), $0)
  // default is: mlir::LLVM::Visibility::Default
  if (!properties.visibility_)
    properties.visibility_ = ::mlir::LLVM::VisibilityAttr::get(odsBuilder.getContext(), mlir::LLVM::Visibility::Default);
}
```

Looks like something is overriding the `constBuilderCall` for the attribute

https://github.com/llvm/llvm-project/pull/73367