[Mlir-commits] [mlir] [mlir] Add support for DIGlobalVariable and DIGlobalVariableExpression (PR #73367)

[Billy Zhu]

================
@@ -37,14 +37,28 @@ void LLVMDialect::registerAttributes() {
       >();
 }
 
+//===----------------------------------------------------------------------===//
+// MDNodeAttr
+//===----------------------------------------------------------------------===//
+
+bool MDNodeAttr::classof(Attribute attr) {
+  return llvm::isa<DIBasicTypeAttr, DICompileUnitAttr, DICompositeTypeAttr,
----------------
zyx-billy wrote:

Can this list be simplified by using DINodeAttr? That way there's no need to add to two places when adding a DINodeAttr?

https://github.com/llvm/llvm-project/pull/73367