[Mlir-commits] [mlir] Reland "[mlir] Fix TileUsingForOp attr-dict printing/parsing" (PR #73261)
Maksim Levental
llvmlistbot at llvm.org
Fri Nov 24 13:57:18 PST 2023
================
@@ -355,7 +355,7 @@ def testTileCompact(target):
@create_sequence
def testTileAttributes(target):
attr = DenseI64ArrayAttr.get([4, 8])
- ichange = DenseI64ArrayAttr.get([0, 1])
+ ichange = Attribute.parse("[0, 1]")
----------------
makslevental wrote:
Ah I didn't see the other test. Anyway I'm not sure what the point of this additional test is (I'm away from my desk so I can't see if this builder is an `ext` builder) but the parse shouldn't be necessary for these attributes because of the registered builders in `ir.py`. Anyway it was just nit type comment.
https://github.com/llvm/llvm-project/pull/73261
More information about the Mlir-commits
mailing list